CRM-20023 Add test showing passing in just state_province_id and coun… #9958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totten
reviewed
Mar 9, 2017
| $params = array('state_province_id' => 1022, 'country' => 'U.S.A'); | ||
| $formatted = CRM_Utils_Geocode_Google::format($params); | ||
| $this->assertTrue($formatted); | ||
| $this->assertEquals('46.729553', $params['geo_code_1']); |
There was a problem hiding this comment.
Perhaps this should be using assertApproxEquals()? It feels weird to assign such a precise coordinate to a landmass as large as the United States.
…try only geoloates based on country not state as well
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20023 Add test showing passing in just state_province_id and coun…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…try only geoloates based on country not state as well