CRM-20157, CRM-20195 Dedupe code cleanup #9907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a class property and a local variable for the same thing just causes confusion
|
@JKingsnorth this is still on the theme of minor code tidy-ups |
eileenmcnaughton
force-pushed
the
dedupe_code
branch
from
a192ec7
to
fcc3d8e
Compare
JKingsnorth
reviewed
Feb 28, 2017
| @@ -282,7 +282,7 @@ public static function retrieve($cacheKey, $join = NULL, $whereClause = NULL, $o | |||
|
|
|||
| if (!empty($select)) { | |||
| $extraData = array(); | |||
| foreach ($select as $dfield => $sfield) { | |||
| foreach ($select as $sfield) { | |||
There was a problem hiding this comment.
foreaches are faster if you specify the index - or so I hear?
There was a problem hiding this comment.
I did a quick google & didn't find anything to support that. Mostly I found for vs foreach - e.g https://coderwall.com/p/il1tog/php-for-vs-foreach-benchmark - but in general most of what I found was php 5.3 or 5.4- I expect it changes each php version
|
@JKingsnorth is this OK to merge? |
|
Sorry, testing this fully now |
|
Tested:
All seems OK. |
|
Thanks again @JKingsnorth |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20157, CRM-20195 Dedupe code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unused variables, remove deprecated fatals.
Unfortunately the deprecated fatals removal made it hard to read as it alters the indentation by adding a try-catch :-( The only change in that commit is the try-catch addition + the removal of the fatals