CRM-20146 dont hardcode check_number toggle in .tpl #9865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lcdservices
commented
Feb 21, 2017
•
lcdservices
commented
- CRM-20146: check_number toggle: don't hardcode value
JoeMurray
reviewed
Feb 21, 2017
JoeMurray
changed the title
|
test this please |
|
Yeah - it is better - although that whole chunk of code looks like it is legacy - I'd be happy to merge it if someone confirms it works |
|
@lcdservices I tested this and this fails for on change of "Payment Method" (changed the check_number value) You might want to remove hard-coded value here as well |
|
@yashodha looks like it's ready for you to recheck & hopefully merge |
|
@eileenmcnaughton tested works fine |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20146 dont hardcode check_number toggle in .tpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.