Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20058, added submit credit card payment link #9860

Merged
merged 2 commits into from
Mar 10, 2017

Conversation

pradpnayak
Copy link
Contributor


----------------------------------------
* CRM-20058: Add Credit Card Payment link for partially paid contribution
  https://issues.civicrm.org/jira/browse/CRM-20058
@eileenmcnaughton
Copy link
Contributor

Do we need to only do this for sites with backoffice processors like we do on backoffice contribution pages - ie. CRM_Financial_BAO_PaymentProcessor::hasPaymentProcessorSupporting(array('BackOffice')

@JoeMurray
Copy link
Contributor

@pradpnayak , I agree we should test along the lines that Eileen suggests. @eileenmcnaughton where would one find the list of values of things like 'BackOffice' ? I'm not sure of exact manner, but it would be good to see that referenced somewhere in the docblock if not in the signature itself.

@eileenmcnaughton
Copy link
Contributor

There are a bunch of functions on CRM_Core_Payment that define the capabilities of the processor.

This function


  /**
   * Is there a processor on this site with the specified capability.
   * @param array $capabilities
   *
   * @return bool
   */
  public static function hasPaymentProcessorSupporting($capabilities = array()) {
    $result = self::getPaymentProcessors($capabilities);
    return (!empty($result)) ? TRUE : FALSE;
  }

checks for capabilities such as

supportsLiveMode
supportsTestMode
supportsFutureRecurStartDate
supportsCancelRecurring
supportsRecurContributionsForPledges(

& a few others
I could add the above to the doc block for that function, but I wouldn't want it to be seen as a complete list

@eileenmcnaughton
Copy link
Contributor

here you go #9941

----------------------------------------
* CRM-20058: Add Credit Card Payment link for partially paid contribution
  https://issues.civicrm.org/jira/browse/CRM-20058
@Edzelopez
Copy link
Contributor

Hi @eileenmcnaughton
I have added the check for backoffice credit card payments. Is this ready to merge?

@eileenmcnaughton
Copy link
Contributor

Yep, thanks @Edzelopez

@eileenmcnaughton eileenmcnaughton merged commit a997401 into civicrm:master Mar 10, 2017
@eileenmcnaughton
Copy link
Contributor

Actually @Edzelopez I guess the mode should not be set to live but figured out? ie. it could be test? This is merged & I'll close & leave it to you to add another ticket for that if you agree

@pradpnayak pradpnayak deleted the CRM-20058 branch March 15, 2017 11:42
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
CRM-20058, added submit credit card payment link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants