CRM-19124 update birth_date to be consistent at point of hook (use da…

[eileenmcnaughton]

…tepicker)

[JKingsnorth]

Currently this creates an inconsistent output in the 'pre' hook for the 'Individual' object - details in JIRA.

[eileenmcnaughton]

@seamuslee001 @JKingsnorth I think I've finally cracked it. I managed to push the formatting down into smarty in a consistent way by assigning smarty_view_format. It's a little weird & magical still, but now consistent with between custom & core dates. If the date is a format that does not include day then it will choose a setting that doesn't.

The hook format should be OK on pre hook now...

[eileenmcnaughton]

I believe CRM-15948 is also fixed in this

[seamuslee001]

ok so

Pre Hook - API from drush

"birth_date":"19911102000000"

Post Hook - API from drush

"birth_date":"19911102000000",

Pre hook contact summary inline update

birth_date":"1991-11-01"

Post hook contact summary inline update

"birth_date":"19911101000000",

Pre Hook Contact Edit screen

birth_date":"1991-11-02"

Post Hook Contact Edit Screen

birth_date":"19911102000000",

[seamuslee001]

I didn't test updating via Import but i think that gives a pretty good coverage. Pre hook still seems a bit all over the shop, However we do have 2 formats now on Pre which is all right. Post hook looks pretty stable now

[eileenmcnaughton]

I think it is a reduction on formats anyway :-)

You think this is good to merge?

[eileenmcnaughton]

NB the key thing in my mind is getting rid of custom formats - there are still 2 formats but none of them look like 04/05/2017 which could be 4 May or 5 April....

[eileenmcnaughton]

Also note this should affect profile pages too

[seamuslee001]

given this appears to be an improvement and a reduction down to 2 formats in the hook output. I think we should merge this as an improvement

[eileenmcnaughton]

thanks @seamuslee001