Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20020 - fix search with parent groups + other criteria #9836

Merged
merged 2 commits into from
Mar 12, 2017

Conversation

jmcclelland
Copy link
Contributor

@jmcclelland jmcclelland commented Feb 14, 2017

Previously, search always returned all contacts in the specified
group rather than contacts who also met the added criteria.


Previously, search always returned all contacts in the specified
group rather than contacts who also met the added criteria.
Copy link
Contributor

@MegaphoneJon MegaphoneJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested this PR in production - but that was before the second commit. From looking at the code, I don't see how adding parentheses could possibly cause a problem though.

@eileenmcnaughton
Copy link
Contributor

I'm going to merge this based on @PalanteJon review

@eileenmcnaughton
Copy link
Contributor

btw I have to say this... should really have a test!

@eileenmcnaughton eileenmcnaughton merged commit dad2a90 into civicrm:master Mar 12, 2017
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
CRM-20020 - fix search with parent groups + other criteria
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants