CRM-19970 - Too big amount saved despite error #9789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: setup authorize.net payment issue donation of huge amount (in my case $1,250,000 - one million) response is error, yet contribution is saved as successful Problem lies in how authorize net is handling error. It's simply marked as failed (and problably later marked as completed). Response from auth.net API is: code=3, message=The transaction amount submitted was greater than the maximum amount allowed.
|
Can one of the admins verify this patch? |
|
NB: JMA fixed an issue with auth.net errors silently being ignored. @pradpnayak could you link to that PR and see if there is overlap. |
|
I'm going to merge this as it's clear an error should be thrown in this instance. I'd prefer this function to throw the error, but the calling function (doPayment) should throw an error in this instance |
eileenmcnaughton
changed the title
|
Can one of the admins verify this patch? |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-19979 - Too big amount saved despite error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
setup authorize.net payment
issue donation of huge amount (in my case $1,250,000 - one million)
response is error, yet contribution is saved as successful
Problem lies in how authorize net is handling error. It's simply marked as failed (and problably later marked as completed).
Response from auth.net API is: code=3, message=The transaction amount submitted was greater than the maximum amount allowed.