CRM-19914 - civicrmHooks.php issues on windows

[fliespl]

The problem is that on Windows path might resolve differently, because of notation. Problem is that even if file exists it will not be included (silent error ignore) in specific cases (directory names).

---

• CRM-19914: civicrmHooks.php issues on windows

[civicrm-builder]

Can one of the admins verify this patch?

[seamuslee001]

This looks sensible @eileenmcnaughton what you think? can you ok to test this pls

[eileenmcnaughton]

test this please

[eileenmcnaughton]

It makes sense - I guess we do need to load a wordpress site with this & ensure a basic contact edit still works

[kcristiano]

@eileenmcnaughton I have tested this on latest master. I have added the patch and then installed a number of WP plugins that rely on hooks. All are working as expected.

@christianwach Can you review this as well?

[christianwach]

Haven't tested this specifically, but I'd say it's a sensible addition. I've just debugged a scenario where CiviCRM's use of set_include_path() was interfering with the loading of files in another plugin in just the same way. The solution was to be specific about the path to the file.

[fliespl]

@christianwach That's correct. I have also experienced the same issue here CMB2/CMB2#886

[kcristiano]

Thanks for the feedback @christianwach based on my testing and the comments I do believe this should be merged as soon as practical for RC testing