CRM-19663: A scheduled reminder set to use an absolute date does not allow repeats #9773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
monishdeb
commented
Feb 3, 2017
•
monishdeb
commented
- CRM-19663: A scheduled reminder set to use an absolute date does not allow repeats
|
Jenkin test this please |
CRM/Admin/Form/ScheduleReminders.php
Outdated
| } | ||
| } | ||
| foreach ($moreKeys as $mkey) { | ||
| $params[$mkey] = CRM_Utils_Array::value($mkey, $values); |
There was a problem hiding this comment.
@monishdeb Seems this change provides and extra ability to fill the values for absolute as well as relative dates. As I was able to save both dates in the form, I think $moreKeys looping here should be containing only repetition field values.
jitendrapurohit
approved these changes
Apr 6, 2017
There was a problem hiding this comment.
@monishdeb I've pushed the fix for additional issues I found. This could be merged now.
jitendrapurohit
force-pushed
the
CRM-19663
branch
from
d08be6f
to
39bf7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.