CRM-19937 - ensure amount preceded by $ is still treated as a number #9745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the payment fields will not be shown.
|
This is a good idea but probably should also handle currency symbols that aren't the dollar sign.
|
|
I'm not sure how to test for any currency symbol... but we could test if the first character is not a number and if so strip it off and test the rest of the string to see if it's a number. |
| @@ -150,7 +150,8 @@ function calculateSelectLineItemValue(priceElement) { | |||
| */ | |||
| function calculateText(priceElement) { | |||
| //CRM-16034 - comma acts as decimal in price set text pricing | |||
| var textval = parseFloat(cj(priceElement).val().replace(thousandMarker, '')); | |||
| //CRM-19937 - dollar sign easy mistake to make by users. | |||
| var textval = parseFloat(cj(priceElement).val().replace(thousandMarker, '').replace('$', '')); | |||
There was a problem hiding this comment.
@jmcclelland I see we already have currency symbol in a symbol variable as we have for thousandMarker. We should be able to replace the same using:
.replace(thousandMarker, '').replace(symbol, ''));
Can you please try this and check if it works for you ?
Thanks.
|
Ah... symbol - didn't see that. Great idea. I just made the change. |
|
Based on the review above and my own reading of the code I think this is good to merge |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-19937 - ensure amount preceded by $ is still treated as a number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise the payment fields will not be shown.