CRM-16228 - Tax INVOICE PDF Tax Rate - Incorrect - 4.6 LTS #9627
Conversation
My preference would be no rounding it all at this stage (this tax_amount is carried into the calculations where it's multiplied by quantity) - but let's be safe and set it to 4 decimals for now;
|
@seamuslee001 - any thoughts as to why I'm getting: api_v3_CustomValueTest::testCreateCustomValue Failed asserting that false matches expected true. PR tests fine in 4.7: #9626 - and it does not touch on any custom values. |
|
Jenkins re test this please |
|
Note to self: write PHPUnit test to check tax amounts calculated. |
|
Can't get a PHPUnit test going without also editing Core itself in some important places; it's too risky - it defies the point of having make sense/simple/safe PRs for LTS. |
|
I was able to send monies to PayPal WPS - (see below: this was 4.6.x front end contribution page w/ Membership priceset - Membership - ($0.52 + 5% GST ($0.026) = $0.546 = $0.55 ) - but there are so many ways to get CiviCRM to send monies to Paypal WPS it would be good if a third party could confirm that removing the premature rounding in this PR does not cause any issues there. If it does I'll want to add a fix for that to this PR before it gets merged - @jackrabbithanna
|
|
I just found out that @mlufty had already fixed the rounding issue on price_fields back in Aug. 2015: https://issues.civicrm.org/jira/browse/CRM-17034 - #6520 - just trying to refix that :-) |
|
Closing this as I have a more comprehensive solution - please see: |
My preference would be no rounding it all at this stage (this tax_amount is carried into the calculations where it's multiplied by quantity) - but let's be safe and set it to 4 decimals for now;