Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-19829 - Add crmThrottle angular util #9624

Merged
merged 2 commits into from
Jan 5, 2017
Merged

CRM-19829 - Add crmThrottle angular util #9624

merged 2 commits into from
Jan 5, 2017

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 3, 2017 •
edited by civicrm-builder
Loading

@totten
Copy link
Member

totten commented Jan 3, 2017

  1. From a reading, I think the algorithm does what you described/wanted.
  2. This seems amenable to a unit-test. (If it helps any, there's a test for crmQueue.)
  3. I did a double-take because the semantics of "throttle" are different in here vs https://lodash.com/docs#throttle . However, "throttle" is still a good metaphor.

@colemanw colemanw merged commit 34ce68d into civicrm:master Jan 5, 2017
@colemanw colemanw deleted the CRM-19829 branch January 5, 2017 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CiviCase Backport master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colemanw @totten @civicrm-builder