Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal bootstrap failures should throw debuggable exception #9616

Merged
merged 2 commits into from
Apr 4, 2017

Conversation

ErichBSchulz
Copy link
Contributor

@ErichBSchulz ErichBSchulz commented Jan 3, 2017

Updated Description

Suppose one is submitting a request to a backend entry-point (such as rest.php or cv). If the system an incompatible/incomplete configuration, it could produce a hard exit with the error like Sorry, could not locate bootstrap.inc. However, tracing this error was often difficult because the hard exit did not report a backtrace. This makes the error condition more debuggable.

Original Description

As discussed with @totten in the chat.

I'd like to fix that error_reporting call too but need some guidance first.

@totten
Copy link
Member

totten commented Jan 4, 2017

jenkins, test this please

@eileenmcnaughton
Copy link
Contributor

@totten can you look at this - I believe it is good-to-merge

@totten
Copy link
Member

totten commented Apr 4, 2017

+1 @ErichBSchulz. I test a couple synthetic misconfigurations (e.g. missing bootstrap.inc and running loadBootStrap() by way of cv). This patch means that boot failures experienced in cv are easier to debug/inspect now. :)

@totten totten merged commit cb4100b into civicrm:master Apr 4, 2017
@totten totten changed the title Feature/drupal boot no exit Drupal bootstrap failures should throw debuggable exception Apr 4, 2017
Copy link
Contributor Author

@ErichBSchulz ErichBSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Hope it helps someone sometime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants