[REGRESSION] Replaced inner with left joins to show refunds CRM-19803 #9592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
jenkins, ok to test |
jitendrapurohit
approved these changes
Jan 4, 2017
There was a problem hiding this comment.
Checked record payments, refunds with the PR. All details are listed properly. Added a unit test here - #9634
View Payment Page -
Contribution Tab -
@pradpnayak Currently financial_type is not being shown for refund transaction after this PR. Does this need an extra handling for the same? Meanwhile, I think this can be merged as it fixes the immediate regression.
monishdeb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to show the refund in the view payments popup of the Participant Form.