Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19806 make CiviCase only call formlinks once to create action links #9586

Merged
merged 2 commits into from
Jan 9, 2017

Conversation

alifrumin
Copy link
Contributor

@alifrumin alifrumin commented Dec 28, 2016

@jitendrapurohit
Copy link
Contributor

Looks like this part needs to be removed too ? Currently, we have a set of e-notices on dashboard after this PR.

Notice: Undefined index: moreActions in CRM_Case_BAO_Case::getCases() (line 664 of /home/web/civi_master/civicrm/CRM/Case/BAO/Case.php).

@alifrumin
Copy link
Contributor Author

alifrumin commented Jan 3, 2017

I think you are right, I added that change to the PR thanks for the heads up. I think there are some additional css changes needed to make this look right. I will look in to that some more

@alifrumin alifrumin changed the title CRM-19806 make CiviCase only call formlinks once to create action links CRM-19806 make CiviCase only call formlinks once to create action links [wip] Jan 3, 2017
@alifrumin
Copy link
Contributor Author

Actually It looks like the search results are wider then the search form (grey area) on all the search pages.. So that's not related to this pr... see below (both images from test build):

findcontacts

findcases

We could change the text for the third civicase action button from "Assign To Another Client" to "Reassign" that might make it slightly prettier.

@alifrumin alifrumin changed the title CRM-19806 make CiviCase only call formlinks once to create action links [wip] CRM-19806 make CiviCase only call formlinks once to create action links Jan 3, 2017
@colemanw
Copy link
Member

colemanw commented Jan 9, 2017

Actually I don't think we should use the word "Assign" in reference to "Clients" at all since an "Assignee" is a member of staff.
How about "Change client"?

@colemanw colemanw merged commit 8550efb into civicrm:master Jan 9, 2017
@colemanw
Copy link
Member

colemanw commented Jan 9, 2017

That's really a separate issue. I'll merge this and we can think about the language issue.

@alifrumin
Copy link
Contributor Author

"Change Client" sounds good to me. Thank you @colemanw .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants