[ready-for-core-team-review]CRM-19804, added pre and post hook invokation for FinancialAccount #9584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-19804: Pre() and Post() hook for Financial Account https://issues.civicrm.org/jira/browse/CRM-19804
pradpnayak
force-pushed
the
CRM-19804
branch
from
da0cd0a to
afa09af
Compare
monishdeb
reviewed
Dec 28, 2016
| $op = 'create'; | ||
| if (!empty($params['id'])) { | ||
| $op = 'edit'; | ||
| } |
There was a problem hiding this comment.
@pradpnayak isn't this a repetition? I mean can we not initialise the $op parameter once ? and need optimisation
$op = empty($params['id']) ? 'create' : 'edit';
There was a problem hiding this comment.
I think one can change the $params values in pre hook i.e they might unset($params['id']) when $op == 'edit' which will end up creating new entry in db rather update and hence post hook should invoke as $op == 'create'.
$op = empty($params['id']) ? 'create' : 'edit';
I was told by one of member from core team in past to use if () condition rather ternary operators. If this pattern is allowed i happy to optimize it and use it in future :)
pradpnayak
changed the title
jitendrapurohit
approved these changes
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-19804