CRM-19802 - Fix translated strings in tpl

[colemanw]

• CRM-19802: Contribution page : missing translation

[colemanw]

@civicrm-builder retest this please

[totten]

+1

FWIW:

• I was wondering about whether there was a way to handle the Javascript ts('...') snippet generically (like we do in Angular *.html files)... it may be feasible for civistrings to extract calls to ts(...) from *.tpl files, but... at runtime... I don't think there's a simple way to populate CRM.strings with the right translations. (You'd have to understand the different flows for loading *.tpl.)
• Based on grep, there are a few other files which look to have suspicious ts(...) calls inside Smarty content. These shouldn't block 9581 but may be similar issues:
  • templates/CRM/Campaign/Form/Task/Interview.tpl
  • templates/CRM/Contribute/Form/Contribution/Main.tpl
  • templates/CRM/Event/Form/EventFees.tpl
  • templates/CRM/Event/Form/SelfSvcUpdate.tpl
  • templates/CRM/common/enableDisableApi.tpl
  • templates/CRM/common/navigation.js.tpl

[colemanw]

@totten Right, it's not just a matter of extracting the civistrings it's also a matter of adding the strings into the DOM.
When to use ts() vs {ts} is confusing but I have documented it.