CRM-19447 activity details search

[twomice]

This applies the requested changes from CRM-19447, on both the Activity Search and the Advanced Search.

---

• CRM-19447: Improve Activity Subject/Details text search to be similiar to Notes Subject/Body

[monishdeb]

@twomice you can also add unit test on search form's formValues. Lemme cite an example https://github.com/civicrm/civicrm-core/pull/9506/files#diff-ebb82d7b9ab678b644e21a15f37a8e86R162

[twomice]

Thanks, @monishdeb. I will look at these.

[twomice]

@monishdeb Regarding "you can also add unit test on search form's formValues": from the example, I'm not sure what I'm really testing, and accordingly where to locate the test (e.g., tests/phpunit/CRM/Contact/BAO/...what?) Can you offer any insight?

[monishdeb]

@twomice here's few example how you can add unit-test on Search Form's form-values and even Qill string too.

1. using Smart and/or Regular group filter testContactCombineGroupSearch in Advance Search
2. using Group Type filter testbyGroupType in Advance Search
3. using 'Is Batch' filter testBatchFilter in Find Contribution .

[twomice]

Sorry to ask @monishdeb, but Jenkins testing is failing to merge the PR now:

error: patch failed: CRM/Activity/BAO/Query.php:192
error: CRM/Activity/BAO/Query.php: patch does not apply
error: patch failed: CRM/Activity/Form/Search.php:195
error: CRM/Activity/Form/Search.php: patch does not apply
(https://test.civicrm.org/job/CiviCRM-Core-PR/13156/console)

Any suggestions what I can do to fix this?

[monishdeb]

@twomice I have updated the PR and test build passes :)

U might have missed --rebase, reason why there was a false merge commit.
Always do git pull --rebase upstream master to update your PR and in order to squash multiple commits into one do git rebase -i .. it will open a interactive console in vi edit.

[twomice]

Thanks @monishdeb! Let me know if the PR needs more work.

[monishdeb]

@twomice will do the QA. However some might want to have separate search filters for Activity details and subject respectively for sake of simplicity. But the current feature gives the ability to use the same filter for activity detail and/or subject, that's better

[twomice]

@monishdeb The intent of the functionality as describedin the ticket CRM-19447 is to emulate the behavior seen for Notes, as in Advanced Search > Notes > Note Text, with options "Body Only / Subject Only / Both". So this PR aims to do what's called for in the ticket. Hopefully that's acceptable.

[monishdeb]

Oh ok, very well proceeding with QA. There are few scope for optimization and will update this PR with those changes.

[monishdeb]

@twomice did some additional changes 1cd7479 please have a look. Will merge then after test builds passes

[monishdeb]

Top of the changes

[twomice]

Those are great changes, @monishdeb Thanks for that, and for the merge!