CRM-19856 Fix Drupal 8 get User url

[seamuslee001]

• CRM-19856: Get User record url fails in Drupal 8

[yashodha]

@seamuslee001 : Is there a related issue in JIRA for the same?

[seamuslee001]

@yashodha Have just created one CRM-19856 also pinging @jackrabbithanna as I know mark has been working on D8 stuff lately

[jackrabbithanna]

Where was the User link broken, what are the steps to replicate? There's also going to need to be other issues around the User/profile stuff as the integration of Profiles on user view and edit is broken
UPDATE the profile stuff I mentioned is bugs in civicrm-drupal not civicrm-core

[seamuslee001]

@jackrabbithanna Mark from looking at the information that was supplied into Matermost it looks like it is the link to the user account from on the CiviCRM Contact Record page i think

[jackrabbithanna]

Jenkins, retest this please.

[jackrabbithanna]

@seamuslee001 @yashodha
I can confirm this fixes the issue. I'm running the tests again, and if it passes we'll merge this in

[jackrabbithanna]

@totten the tests have passed and this should be merged in. I could merge it in but I'm unclear whether I'm to stick with only merging into the 4.6 branch, or have authorization to merge Drupal 8 related PRs into the master branch

[jackrabbithanna]

@colemanw what do you think?

[eileenmcnaughton]

Ok so this is not a 'Drupal8' only pr - it is intended to fix a drupal 8 issue, but it does so in shared code. So, to speak to the safety of merging it....

The change is in the DrupalBase class - so only Drupal 6,7 & 8 will be affected.

The change is from a direct drupal function to generate a drupal url to calling a CiviCRM function to generate it. The CiviCRM function is also part of the drupal base class. The arguments on the replacement function match the arguments of the drupal function with the same defaults - so I think this function should perform the same as the previous function for d6 & d7 and am happy to merge it.