Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19626: Add min-amount handling to priceset #9517

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Dec 8, 2016

@monishdeb
Copy link
Member

monishdeb commented Dec 8, 2016

UI Review

  1. Created price-set that support minimum amount 0
    image

  2. two Price fields created, one with text numeric and second select field with price-option $0

  3. On Event registration page selected $0 price option
    image

  4. Was able to register successfully.
    image

Also checked with all kind of price fields, it works fine. Checked with non-zero minimum amount and validation is respected well if user submit amount lesser then allotted minimum amount.

@jitendrapurohit jitendrapurohit force-pushed the CRM-19626-2 branch 3 times, most recently from 2133743 to 601c7a2 Compare December 14, 2016 06:53
@yashodha
Copy link
Contributor

yashodha commented Dec 14, 2016

merging as it is working as per comments

@yashodha yashodha merged commit e0e8e7e into civicrm:master Dec 14, 2016
@jitendrapurohit jitendrapurohit deleted the CRM-19626-2 branch December 14, 2016 11:39

-- CRM-19626
ALTER TABLE civicrm_price_set ADD min_amount INT(10) UNSIGNED DEFAULT '0' COMMENT 'Minimum Amount required for this set.';
Copy link
Member

@colemanw colemanw Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jitendrapurohit @yashodha Putting schema changes directly into the sql file means that an upgrade will fail if run twice (e.g. in the case of upgrading an RC -> stable). I've added a utility for safely adding columns (and we could add more such utilities for other small tasks like this) and moved this code here: #9548

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colemanw Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants