Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - CRM-19701: Amount not formatted for currency without symbol. #9476

Closed
wants to merge 1 commit into from
Closed

WIP - CRM-19701: Amount not formatted for currency without symbol. #9476

wants to merge 1 commit into from

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Dec 1, 2016 •
edited by civicrm-builder
Loading

@jitendrapurohit jitendrapurohit changed the title CRM-19701: Amount not formatted with currency without symbols CRM-19701: Amount not formatted for currency without symbol. Dec 1, 2016
@jitendrapurohit
Copy link
Contributor Author

test this please

@pradpnayak pradpnayak mentioned this pull request Dec 5, 2016
Merged
@pradpnayak
Copy link
Contributor

Tested, PR replaces civicrm_currency.symbol with civicrm_currency.name for missing currency symbol.
But as per Latest Coleman comment on issue, the PR should contain symbol's for missing currencies and should ignore symbol's for missing ones.

@jitendrapurohit jitendrapurohit changed the title CRM-19701: Amount not formatted for currency without symbol. WIP - CRM-19701: Amount not formatted for currency without symbol. Dec 8, 2016
@monishdeb monishdeb added the needs-work-not-review-ready Submitter required to take action, will be closed after 1-2 weeks in this state label Dec 8, 2016
@jitendrapurohit
Copy link
Contributor Author

closing this as per comment on https://issues.civicrm.org/jira/browse/CRM-19701?focusedCommentId=97505&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-97505

@jitendrapurohit jitendrapurohit deleted the CRM-19701 branch December 8, 2016 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master needs-work-not-review-ready Submitter required to take action, will be closed after 1-2 weeks in this state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jitendrapurohit @pradpnayak @monishdeb @civicrm-builder