CRM-19678: No Membership Renewal Activity is created when a Pay Later is set to Completed

[monishdeb]

• CRM-19678: No Membership Renewal Activity is created when a Pay Later is set to Completed

[eileenmcnaughton]

I'm very happy with this from a code point of view. I haven't tested it though. @Stoob I think you have an interest in this? If you want to test it I'm happy to merge. (do you know how to get from the PR to the test build for the PR? We need to document that).

[eileenmcnaughton]

I'll tell you if you promise to document it somewhere.

When the Jenkins tests run they create a demo site which is kept for around a week. To get the url for it you click on the green arrow (hopefully - sometimes a red cross) to the jenkins test results. On the left hand side you will see a link to 'Console Output' and when you click on there you will see a link 'full log'.

Search within those results for '--url=' - just after that string you will see a link to the build. In this case http://core-9447-1ilfw.test-ubu1204-5.civicrm.org/

You can find the admin user & password by searching for '--account-name=' - although they always seem to be pradmin/pradmin1234

[monishdeb]

@eileenmcnaughton I think this - https://wiki.civicrm.org/confluence/display/CRMDOC/Testing would be appropriate place to document the explanation under PR (Pull Request) Testing headline, with screenshot of console output section, where to find the credential. What ya say ?

[eileenmcnaughton]

Yep perfect & @Stoob has agreed to do the documentation

[monishdeb]

ok will wait for the @Stoob doc. but meanwhile can I this merge this PR as it is tested by @jitendrapurohit too?

[eileenmcnaughton]

Yep - it's a simple PR and as long as someone has tested it !

[petednz]

Just trying to test this. Workflow I am testing is

• add a new membership to a contact and ensure it 'active' (eg if done as Pay Later then needs to be completed)
• return to conbtrib page in order to renew using Pay Later

Outcome expected

• Membership Renewal will only be created (or set to Completed) once the Payment is Completed.

Outcome observed

• 2 x Membership Renewal activities are showing on the Activity Tab and both were set to Completed even though the Contribution is still set to Pay Later

Either I am mis-testing, or mis-understanding what the fix was attempting

[monishdeb]

@petednz my use-case was

1. Do pay-later contribution via online contribution page (https://github.com/civicrm/civicrm-core/pull/9447/files#diff-40e2e0f106ba620465acf3a9a81f2498R2509)
2. Complete contribution via backoffice "Edit Contribution" either in test or live mode (https://github.com/civicrm/civicrm-core/pull/9447/files#diff-40e2e0f106ba620465acf3a9a81f2498R2547)

Will check your use-case too !!

[petednz]

@monishdeb i think we are testing the same. But remember we are testing Membership Renewal so

• a membership must already exist with a completed payment
• then undertake a renewal using Pay Later
• check and see if at that point (ie before the Contribution is Completed) you have any Membership Renewal activities
  My testing showed me I had 2 such Activities before I got to step 3

[monishdeb]

Thanks @petednz for providing the steps, able to replicate it. Will fix it and try to add unit test this scenario too