New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-19660: Financial Transaction stores wrong transaction date if the… #9405

Merged

eileenmcnaughton merged 2 commits into civicrm:master from jitendrapurohit:CRM-19660

Nov 22, 2016

Contributor

jitendrapurohit commented Nov 17, 2016 •

edited

Loading

… contribution is cancelled.

https://issues.civicrm.org/jira/browse/CRM-19660


          CRM-19660: Financial Transaction stores wrong transaction date if the…

8a0c74a

… contribution is cancelled

yashodha added the master label

Contributor

eileenmcnaughton commented Nov 21, 2016

Can we get a unit test on this?

Contributor Author

jitendrapurohit commented Nov 21, 2016 •

edited

Loading

Sure, just waiting for conformance of what the actual value for trxn_date must be - now() or the cancel_date entered - https://issues.civicrm.org/jira/browse/CRM-19660?focusedCommentId=96726&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-96726


          add unit test

0a8160e

Contributor

eileenmcnaughton commented Nov 22, 2016

Looks good to me

eileenmcnaughton merged commit 24992c9 into civicrm:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels