CRM-19600: Membership Renewal activity not created through online contribution page #9357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eileenmcnaughton it's regression due to refactoring changes done in 4.7 and issue arises when we call
CRM_Member_BAO_Membership::renewMembership(...)
here before its rightful place i.e. is aftercompleteTransaction(...)
here As a result of which additional info is not updated as in here 'Membership Renewal' activity. Although there are other alternatives like handling :Membership.update
apiMembership::create(...)
BAO fn by fetching current membership infobut I think this patch is more appropriate and safe
Tried to add unit test to assert membership-renewal activity via online contribution but currently its not possible.