(NFC) CRM-19606 : provide help text for providing mysql port info #9354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-19606: Provide help text in installer to provide mysql port, if mysql is running on different port https://issues.civicrm.org/jira/browse/CRM-19606
|
Can one of the admins verify this patch? |
|
jenkins, ok to test |
|
This seems to be creating a little mess on the installation page. Can we add |
| @@ -98,6 +98,7 @@ | |||
| <h4><?php echo ts('CiviCRM Database Settings'); ?></h4> | |||
| <p style="margin-left: 2em" id="mysql_credentials"> | |||
| <label for="mysql_server"> <span><?php echo ts('MySQL server:'); ?></span> <input id="mysql_server" type="text" name="mysql[server]" value="<?php echo $databaseConfig['server']; ?>" /></label> <br /> | |||
| <span><?php echo ts('If your mysql server is running on other port then default 3306, provide server info as server:port (i.e. localhost:1234) ') ?> </span> </br> | |||
There was a problem hiding this comment.
I think the message should be (If your mysql server is running on a port other than default 3306, provide server info as a server:port (i.e. localhost:1234)). Note the typo then**. Also we need to remove above <br> tag to display this inline to db textbox.
---------------------------------------- * CRM-19606: Provide help text in installer to provide mysql port, if mysql is running on different port https://issues.civicrm.org/jira/browse/CRM-19606
|
Tested the PR. Installation page looks like -
|
|
Congrats @sharique for your first PR :) |
|
Can one of the admins verify this patch? |
|
@monishdeb Thanks. Hopefully more to come. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to Civicrm, starting with a small patch.
https://issues.civicrm.org/jira/browse/CRM-19606