CRM-19601 is_email_receipt is ignored #9353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter is_email_receipt ignored
|
I think we should make sure we have a test for this before we merge it. However, you may be in luck - a new contributor has shown an interest The starting point would be this test https://github.com/fuzionnz/civicrm-core/blob/257ab382cb93c70223247f03d0b6a353279e96a0/tests/phpunit/api/v3/ContributionTest.php#L2247-L2247 |
|
Looking at this now - testing/QA the PR as well adding a test for it. |
|
This is working fine - just tested this for a variety of conditions. Setting up to write a test for it now. |
This was referenced Nov 16, 2016
|
Test added by @KarinG !!! |
|
NB - I will note on that PR how it could be extended - there was someone looking at doing a test for this PR & that extension would be useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set values from the contribution page, we're potentially over-writing the input parameter which should have precedence. The earlier attempt to set the value might now be redundant, but it might also be used for other components besides civicontribute.