CRM-19397: Don't perform i18n re-write when saving data to cache #9310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-19397: Notice error: unserialize(): Error at offset when searching on contacts https://issues.civicrm.org/jira/browse/CRM-19397
|
I'm not familiar enough with the purpose of the i18n rewrite - what does it do? |
|
I added more details on the JIRA issue, but reviewed the patch and did a pretty good amount of testing to confirm that the patch solves the issue. It does make me wonder whether we often save multi-lingual data in the cache (ex: field labels/descriptions). It seems to be the case here, but I don't see any bug in the UI related to it. If it's the case, it's a separate issue, since the cache was never i18n-aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why no one's reported this yet, but it is happening at our site on 4.7.12, and the changes to fix seem pretty logical.
https://issues.civicrm.org/jira/browse/CRM-19397