CRM-19543: Fix integer 0 validation for pseudoconstants

[jitendrapurohit]

array_search incorrectly returns the first key when integer 0 is searched on an array of strings. This creates an entity with first value of a pseudocontant.

For eg: Grant is created with Submitted status, Membership is created with New status, etc.

Update: Instead of handling it with array_search, moved this validation to a separate if check as it was failing only for 0 value.

@colemanw Any thoughts ?

---

• CRM-19543: api fields set to '0' are not passed to _civicrm_api3_api_match_pseudoconstant for validation

[colemanw]

What about casting 0 to a string '0'? would that make array_search behave correctly?

[jitendrapurohit]

yes, that will work, but main issue is slight different now of changing isset() to !empty() which I did in my first commit 4d1d9ae#diff-3076917760efeb467459726ebb6af282R2175 results into some test failures as it allows empty string '', empty array(), into _civicrm_api3_validate_integer() to check.

Either we can fix all of them or proceed with this separate handling approach.

[jitendrapurohit]

@colemanw Can you merge this, if it looks good to you ?

[colemanw]

I think the casting is a better fix, assuming the tests pass: #9320