Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-17869 - Revert custom field date search refactoring to support relative dates #9304

Merged
merged 3 commits into from
Oct 29, 2016

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 20, 2016

@colemanw colemanw force-pushed the CRM-17869 branch 3 times, most recently from dc9f360 to 2af944c Compare October 23, 2016 18:17
@monishdeb
Copy link
Member

Great work! Happy to test this improvement when its ready :)

@colemanw
Copy link
Member Author

@monishdeb it's ready for review. Thanks.

@monishdeb
Copy link
Member

@colemanw tested on each component's Search form, working like a charm. However I encountered a issue with saved date range criteria of a smart group. Steps to replicate -

  1. Selected custom date field of range - 1st Oct to 31st Oct on Advance Search
  2. Created smart group on above date range criteria.
  3. On edit Smart group criteria form, the date range widget is broken
    image

And these are default values in ISO format

...
    [custom_8_to] => 2016-10-31 23:59:59
    [custom_8_from] => 2016-10-01 0:00:00
...

As per my earlier change here. Is this the expected format ?

@monishdeb
Copy link
Member

@colemanw this is my PR #9334 on top of your patch and its working fine
image

@colemanw colemanw merged commit 1c0fed1 into civicrm:master Oct 29, 2016
@colemanw colemanw deleted the CRM-17869 branch October 29, 2016 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants