CRM-19547 rationalise expensive use of exactMatch search on quicksearch #9301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
quicksearch
branch
3 times, most recently
from
e9611f6
to
80f8b99
Compare
- do not do exact match when the string is just a wildcard (it will never be an exact match) - do not do exact match when the search is an email & there is no @ (it will never be an exact match) - do not do exact match when the search is for sort_name and prepending wildcards is disabled for the site (it is functionally equivalent Change-Id: I17506264eb24f88b6818b014ce248580df1d962c
eileenmcnaughton
force-pushed
the
quicksearch
branch
from
80f8b99
to
613643e
Compare
|
Code looks good and includes lots of tests. |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Dec 30, 2016
- do not do exact match when the string is just a wildcard (it will never be an exact match) - do not do exact match when the search is an email & there is no @ (it will never be an exact match) - do not do exact match when the search is for sort_name and prepending wildcards is disabled for the site (it is functionally equivalent Upstream PR civicrm#9301 Upstream PR includes unit tests Bug:T147344 Change-Id: Ie2593cd37f98be5a43d3a606121d679b03aa2952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is functionally equivalent