CRM-19456 - avoid horizontal scrolling #9173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no-wrap is specified, pages such as the Manage Groups and the Activities tab will require horizontal scrolling because the descriptions won't wrap.
seamuslee001
approved these changes
Oct 7, 2016
|
@jmcclelland this looks like a dup of #9145 / https://issues.civicrm.org/jira/browse/CRM-19245 which has already been merged. |
|
@jmcclelland - wondering what you think of the alternate strategy here: https://github.com/civicrm/civicrm-core/pull/9145/files @tschuettler - any thoughts on this as an alternative to your fix? |
|
I prefer the broader reach of my patch - since it is not just the manage group page - it also affects the activities tab and probably more places. |
|
@colemanw @jmcclelland - same here. I'm merging this in and going to revert 9145 here #9220 |
f2boot
pushed a commit
to f2boot/civicrm-core
that referenced
this pull request
Oct 12, 2016
This reverts commit 5b2b04c. Superceded by civicrm#9173
|
@michaelmcandrew looks good to me. |
JohnFF
pushed a commit
to JohnFF/civicrm-core
that referenced
this pull request
Oct 23, 2016
This reverts commit 5b2b04c. Superceded by civicrm#9173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no-wrap is specified, pages such as the Manage Groups and the
Activities tab will require horizontal scrolling because the
descriptions won't wrap.