CRM-19353 - 'Dedupe by email' not working 2 #9059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@civicrm-builder add to whitelist |
colemanw
requested changes
Sep 26, 2016
|
test this please |
|
Jenkins re test this please |
| @@ -4335,7 +4336,10 @@ public static function apiQuery( | |||
| $sql = "$select $from $where $having"; | |||
|
|
|||
| // add group by | |||
| if ($query->_useGroupBy) { | |||
| if(!empty($groupBy)) { | |||
There was a problem hiding this comment.
@hakuren you need to do if ( not if(
|
We discussed this at the sprint & we had some concerns
I'm going to close this PR because it is against an out of date RC. I'd encourage you to open a new ticket for the outstanding issue around test recipients being deduped, since I think #9214 resolved CRM-19353 - (unless you no longer care) Are you on the dev email list? It would be a good place to discuss adding group_by to the api? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRM-19353: 'Dedupe by email' not working