(NFC) CRM-19323: Advanced search relationship date clause description… #9000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are inaccurate.
|
Can one of the admins verify this patch? |
|
jenkins, ok to test |
|
@ravi-sharma Ravi, I think the end date quill was correct in the current code, I.e, if we are searching for end dates from x date it would be on or after x date and the to is on or before. Where as for start dates it is start date on or after x for where there is a value in the from box and the to date should be on or before x date |
|
@seamuslee001 Thanks for the notes, made few adjustments. Could you please check now? |
|
Hi @ravi-sharma I have tested and the language looks good, this can be merged in now. @totten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s are inaccurate.