Fixes CRM-19308: Disallow false-y values for paths purged during cach… #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
jenkins, add to whitelist |
|
Jenkins re test this please |
1 similar comment
|
Jenkins re test this please |
|
@seamuslee001 is it good to merge ? |
|
I'm going to merge this on the basis that I agree the cleanDirs function SHOULD throw an exception if the target is equal to FALSE (or $!$target ) This is a bit hard to replicate - but at a code level it seems like a fairly clear cut change & does not appear risky to merge this |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
Fixes CRM-19308: Disallow false-y values for paths purged during cach…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e clears.
Fixes: https://issues.civicrm.org/jira/browse/CRM-19308