CRM-15601, CRM-19027 - Fix regression in MyISAM DB check #8930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fa9688 introduced a subtle break in how it skips temp tables: * (Old) `strpos($dao->Name, '_temp') !== FALSE` * (New) `TABLE_NAME NOT LIKE '%temp'` This is relevant when the table name is appended with a randomized suffix. I don't the performance issue being addressed by CRM-19027. If there's an issue with this hurting indexes, then maybe the check should be done in PHP again? Alternatively, maybe we should patch all the code which makes temp tables to enforce `ENGINE=InnoDB`?
|
@eileenmcnaughton , you may be interested since this is a follow up to 3fa9688. |
totten
changed the title
|
Jenkins re test this please |
|
I think this is safe to merge as there is a test associated with it |
seamuslee001
approved these changes
Sep 22, 2016
|
You, sir, are a scholar and a gentleman. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3fa9688 (4.7.10) introduced a subtle break in how it skips temp tables:
strpos($dao->Name, '_temp') !== FALSETABLE_NAME NOT LIKE '%temp'This is relevant when a random suffix is appended to the table name.
I don't know the performance issue being addressed by CRM-19027. If there's an
issue with this hurting indexes, then maybe the check should be done in PHP
again? Alternatively, maybe we should patch all the code which makes temp
tables to enforce
ENGINE=InnoDB?