CRM-18191 CRM-19064 refactor bizareness from PCP create to enable api…

[eileenmcnaughton]

… fn.

This add function is really wierd & blocking writing an api for pcp - this will get past issues in #7878

[eileenmcnaughton]

@PalanteJon - this PR should make your PCP api work properly

[alar77]

I checked this patch against my pcp api ( #9012 )
It basically works but I had to change class CRM_PCP_DAO_PCP &fields function, too.

The change is actually minimal:

// line 171
// from
        'pcp_id' => array(
//to
        'p_c_p_id' => array(

but this class is automatically generated, so I suppose the generator is to be patched in ordered to cope to the non standard "PCP" name.
I dont think I have the time to check and understand the whole code generation thing, so.. who could do that?

[seamuslee001]

As long as tests pass I think this should be good to merge.

[eileenmcnaughton]

Added merge on pass per review by @seamuslee001 & @ggargani

There is a follow up PR for the api

[alar77]

Mayeb I am looking in the wrong place but I still dont see tests for the api

[seamuslee001]

test failure unrelated can be merged

[eileenmcnaughton]

@seamuslee001 are there api tests in the other PR - or just the SyntaxConformance ones?