CRM-18805 - Contribute - record contribution_page_id on recurring tra… #8615
Conversation
…nsactions ---------------------------------------- * CRM-18805: Contribution page not recorded on recurring transactions, Recurring contribution payments do not create CC or BCC emails or profile notifications https://issues.civicrm.org/jira/browse/CRM-18805
|
Can one of the admins verify this patch? |
|
@eileenmcnaughton here's @bsilvern's updated PR |
| @@ -2115,6 +2115,11 @@ protected static function repeatTransaction(&$contribution, &$input, $contributi | |||
| $contributionParams['contact_id'] = $templateContribution['contact_id']; | |||
| $contributionParams['source'] = empty($templateContribution['source']) ? ts('Recurring contribution') : $templateContribution['source']; | |||
|
|
|||
| //CRM-18805 -- Contribution page not recorded on recurring transactions, Recurring contribution payments | |||
| //do not create CC or BCC emails or profile notifications | |||
| if (isset($contribution->contribution_page_id)) //being safe here, not sure if we can ever arrive with this unset | |||
There was a problem hiding this comment.
can you change the if syntax to a 'full if' with curly braces?
…nsactions ---------------------------------------- * CRM-18805: Contribution page not recorded on recurring transactions, Recurring contribution payments do not create CC or BCC emails or profile notifications https://issues.civicrm.org/jira/browse/CRM-18805
|
test this please |
|
@seamuslee001 remind me - I think there was some argument AUG were making against this.... |
---------------------------------------- * CRM-18805: Contribution page not recorded on recurring transactions, Recurring contribution payments do not create CC or BCC emails or profile notifications https://issues.civicrm.org/jira/browse/CRM-18805
|
@eileenmcnaughton I seem to recall Brett didn't like the page information being used for subsequent transactions after the first one as he was feeling the linkage to the contribution page was no longer necessary |
|
hmm - I see the relevance in this context though.. do you know where the ticket is? |
|
@eileenmcnaughton Redmine 9941 and https://issues.civicrm.org/jira/browse/CRM-18357 |
|
My current conclusion is we should merge this as it is consistent with previous versions & opt out can be through Alan's new hook |
|
Test this please Jenkins |
|
test this please |
|
@bsilvern Big congrats on getting your first PR merged into CiviCRM core! Great work! |
|
Can one of the admins verify this patch? |
…nsactions
https://issues.civicrm.org/jira/browse/CRM-18805