Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-18508: Display State/Province in event address in registration emails #8607

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

twomice
Copy link
Contributor

@twomice twomice commented Jun 21, 2016

I'm a little unfamiliar with changes to system message templates. This just changes the template files under xml/templates/. Where would I create a test for this change? Do I need to change anything under sql/, CRM/Upgrade/, or elsewhere?


@eileenmcnaughton
Copy link
Contributor

This is tricky to test - we have loads of tests on the contribution side at the form level so it would be easy to add there - but on the test side we don't have any tests to test submitting the form :-(

Writing a test against CRM_Core_BAO_MessageTemplate::send would be really cool - there are no existing tests though so it would take figuring out how to set that up

@yashodha
Copy link
Contributor

You also need to handle upgrade for the same.
you need to do following steps:

  1. mkdir -p CRM/Upgrade/4.7.x.msg_template/message_templates
  2. cp xml/templates/message_templates/event_offline_receipt_html.tpl CRM/Upgrade/4.7.x.msg_template/message_templates/
    for each of the changed templates
  3. cp CRM/Upgrade/4.7.alpha1.msg_template/civicrm_msg_template.tpl CRM/Upgrade/4.7.x.msg_template/civicrm_msg_template.tpl
  4. Update version in CRM/Upgrade/4.7.x.msg_template/civicrm_msg_template.tpl
  5. Include CRM/Upgrade/4.7.x.msg_template/civicrm_msg_template.tpl in CRM/Upgrade/Incremental/sql/4.7.x.mysql.tpl

You can also check out PR :#6531

@twomice
Copy link
Contributor Author

twomice commented Jun 24, 2016

OK, hmm. Need a few days to make time for this, esp. the testing. Will target by next Wednesday.

@yashodha
Copy link
Contributor

yashodha commented Jul 7, 2016

@twomice Now that 4.7.9 has been released, it would be great to have upgrade in place for 4.7.10.

@yashodha
Copy link
Contributor

tested this, country and state province which were missing are now showing. Upgrade PR will follow.

@yashodha yashodha merged commit c8564cf into civicrm:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants