CRM-18980 Make payment processor selection on event pages multi-site aware again

[MegaphoneJon]

• CRM-18980: Event payment processor selection is no longer multi-site aware

[eileenmcnaughton]

A warning with this - on contribution pages it's possible to lose a payment processor if you save the page on the wrong site of a multi-site - it loads no processor as the configured one is not valid & then saves without a processor, nulling the one that is htere

[MegaphoneJon]

@eileenmcnaughton Sigh - I'm more than aware of this! This issue still exists on contribution pages right now, and existed on event pages in 4.6. Meanwhile, since the payment processor name is public-facing, we tend to name it "Credit Card". Without this patch, there's 12 identical-looking payment processors to choose from and no way to tell which is which.

That said - I have a client who has agreed to fund Nicolas in his multi-site work to make contribution pages multi-site aware, and he's got funding to make event pages multi-site aware. So the "wrong payment processor makes the page invalid" issue should go away for good soon.

[eileenmcnaughton]

cool - there is existing code for things like Campaigns to be less dumb about deleting inaccessible values but yeah that doesn't need to block this

[eileenmcnaughton]

test this please

[eileenmcnaughton]

Is there a ticket for this? It hasn't been caught up in this month's list (which is based on JIRA) as far as I can see

[MegaphoneJon]

Sorry for not including it in the commit comment! This is CRM-18980.

[jaapjansma]

I have reviewed this PR and it seems to be working. @michaelmcandrew could you merge this?

[eileenmcnaughton]

Done - thanks @jaapjansma & @PalanteJon (BTW @PalanteJon is your email still the palante one?)