CRM-18977, fixed code to invoke method in parent class #8594
Conversation
|
| $query->_aliases['civicrm_line_item'] = $alias; | ||
| } | ||
| elseif (!$temp) { | ||
| $query->_aliases['civicrm_line_item'] = 'civicrm_line_item_civireport'; |
There was a problem hiding this comment.
What is impact of specifying an alias for a table that is not used in a report? Are we confident that this will not cause changes to the queries for those reports?
|
@pradpnayak please rebase this PR as it gone stale |
---------------------------------------- * CRM-18977: Contribution reports fails when Financial ACL is enabled https://issues.civicrm.org/jira/browse/CRM-18977
---------------------------------------- * CRM-18977: Contribution reports fails when Financial ACL is enabled https://issues.civicrm.org/jira/browse/CRM-18977
|
Reviewing now. Jenkins retest this please. |
|
I tested this by first observing the fatal error as described in the ticket. I applied the patch, and observe that the fatal error no longer appears. The code looks sound to me. Defining an unused member of the _aliases array should not have any negative impact. It's worth noting that even before this PR, the code is capable of changing the _aliases array value for this table; the change here seems to be simply that it's providing a default value for the alias when it's blank. This patch does affect the desired change (fixes the error), and I don't see anything problematic here. Please merge. |
|
Merged against master for 4.7.11. Pradeep, could you submit another PR for this against 4.7.10-rc ? |
|
Send PR at #8778 |
https://issues.civicrm.org/jira/browse/CRM-18977