CRM-17917 - Fix D8 Civi/Install/Requirements #8592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit confusing because there are two nearly identical classes for checking system requirements -- `install/index.php#InstallRequirements` (used by the graphical D6/D7/WP) and `Civi/Install/Requirements.php` (used by the headless D8 installer). This looks like a code cleanup gone awry. In any event, the DB config objects in these contexts have different properties. This fixes the D8 one to consistently use the D8 properties. WISHLIST: Use the same classes and array structures in each context!
|
Is this still valid? Should we open a new ticket since this one is closed https://issues.civicrm.org/jira/browse/CRM-17917 |
|
jenkins, test this please |
|
I have opened a replacement PR here #9194 |
|
Closing in favour of #9194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit confusing because there are two nearly identical classes for
checking system requirements --
install/index.php#InstallRequirements(used by the graphical D6/D7/WP) and
Civi/Install/Requirements.php(usedby the headless D8 installer). This looks like a code cleanup gone awry.
In any event, the DB config objects in these contexts have different
properties. This fixes the D8 one to consistently use the D8 properties.
WISHLIST: Use the same classes and array structures in each context!