CRM-17281: Fix pledge miscalculation when total amount covers multiple installments #8540
Conversation
mlutfy
added
the
needs-work-not-review-ready
mlutfy
removed
the
needs-work-not-review-ready
|
The test is perhaps a bit weird (it's my second test ever), but the Pledge API does not do the same as the Pledge form, which calls BAO stuff from outside the BAO "create", i.e. the form calls CRM_Contribute_BAO_Contribution::updateRelatedPledge() directly, and the API does not. The pledge BAO code is a bit funky, so I don't want to investigate much further for now. |
|
jenkins, test this please |
|
Heh Mathieu as Release Manager this month, I'm trying to recruit people to help pare down the backlog of almost 100 PRs, some going back to last summer. I'm wondering if you would be able to help QA another PR or two if I got someone to QA this PR and your other one #8516 ? |
|
@jmcclelland would you be interested in QAing this PR? |
|
jenkins, test this please |
|
Jenkin test this please |
|
@mlutfy there is a related test failure https://test.civicrm.org/job/CiviCRM-Core-PR/12156/ Can you fix it ? Marking it with WIP for now |
monishdeb
added
the
needs-work-not-review-ready
|
jenkins, test this please |
|
Noting the jenkins error, for posterity: CRM_Pledge_BAO_PledgePaymentTest::testCreatePledgePaymentForMultipleInstallments /home/jenkins/buildkit/build/core-8540-12hgm/sites/all/modules/civicrm/CRM/Core/Error.php:337 |
CRM-19676: fix how params are merged
---------------------------------------- * CRM-19681: date fields not respected when passed through url for report https://issues.civicrm.org/jira/browse/CRM-19681
---------------------------------------- * CRM-19681: date fields not respected when passed through url for report https://issues.civicrm.org/jira/browse/CRM-19681
CRM-19641 Further Fix
4.7.14-rc merge
CRM-19789: Re-add qill getter
CRM-19777: Edit contribution : wrong decimal separator on total_amount
OptionValue Api cleanup - remove unnecessary lookup
During development of FlexMailer, I flirted with using a special token (e.g.
`{actions.trackOpen}`) but ultimately found that was positioned well in
the order of operations.
* Update joomla.css * Update joomla.css * Update joomla.css
CRM-19690 - CRM_Mailing_Tokens - Add TokenProcessor support
…ntribution is updated Added test ---------------------------------------- * CRM-19585: Sales tax issue https://issues.civicrm.org/jira/browse/CRM-19585
CRM-19761 support docx, etc export
…articipant registration ---------------------------------------- * CRM-19288: VAT not included for additional participant fee when registering for events https://issues.civicrm.org/jira/browse/CRM-19288
---------------------------------------- * CRM-19288: VAT not included for additional participant fee when registering for events https://issues.civicrm.org/jira/browse/CRM-19288 CRM-19288, removed white space ---------------------------------------- * CRM-19288: VAT not included for additional participant fee when registering for events https://issues.civicrm.org/jira/browse/CRM-19288
CRM-19690 - CiviMail - Add MailingSystemTest. Small code cleanups.
[ready-for-core-team-review]CRM-16189, Code to add 'Record Payment' link on Contribution View and Contribution tab
[ready-for-core-team-review]CRM-19288, fixed civicrm_contribution.tax_amount value for multiple p…
CRM-19690 - crmMailingBlockRecipients - Provide selector for more downstream styling
[ready-for-core-team-review]CRM-19585, created function to calculate financial item amount when co…
CRM-19244 Custom fields with option group not importing
…ger and a payment is received covers multiple installments.
…han the usual installment amount.
|
I messed up this PR while attempting to rebase. Opened a new PR in #9585. |
|
you must have missed --rebase option i.e. |
I also cleaned up the style, to replace, for example:
$statues[1] = array_search('Overdue', $contributionStatus);
with:
$statues[1] = $contributionStatuses['Overdue'];