CRM-18251 - Domain stats and VersionCheck #8525

twomice · 2016-06-07T08:31:08Z

CRM-18251: Pingback improvements

twomice · 2016-06-07T17:24:37Z

Jenikins retest this please.

twomice · 2016-06-07T17:54:37Z

@nganivet Can you review this please? Thanks!

nganivet · 2016-06-08T18:52:17Z

CRM/Utils/VersionCheck.php

+          $this->stats['domain_country_iso'] = $country_result['iso_code'];
+        }
+      }
+    }


Should we explicitly:
} else {
$this->stats['domain_country_iso'] = NULL; (or '';)
}
??

JoeMurray · 2016-06-13T16:48:40Z

Heh Allen as Release Manager this month, I'm trying to recruit people to help pare down the backlog of almost 100 PRs, some going back to last summer. I'm wondering if you would be able to help QA another PR if I got someone to QA this PR?

twomice · 2016-06-13T17:39:21Z

Yes, sure. But note that this PR is not ready, per Nicola's review comment above, so we don't want to review it yet, not until tomorrow when I should have this fixed.

twomice · 2016-06-16T17:17:32Z

Jenikins retest this please.

twomice · 2016-06-17T14:49:39Z

jenkins, test this please

totten · 2016-06-17T20:57:02Z

jenkins, test this please

twomice · 2016-06-17T23:12:01Z

jenkins, test this please

nganivet · 2016-06-19T06:41:58Z

@twomice: can you send a test ping from one of your instances and I will check that all params are received? I have just checked in the stats DB and there does not seem to be any values for either the country ISO or the Delivered entity.

twomice · 2016-06-20T02:11:13Z

@nganivet OK, I've done that now. This site reported domain_isoCode = 'AF'.

twomice · 2016-07-12T14:18:54Z

Jenins retest this please

eileenmcnaughton · 2016-07-19T00:36:03Z

Just a quick note that we are nearly to the end of review for this cycle - looks like it's almost in but you probably need to merge it tomorrow to make 4.7.10.

But if you 'just miss it' I think it's Ok to merge when done rather than wait for next review week as review is actively happening here

eileenmcnaughton · 2016-07-25T23:55:11Z

I'm setting the JIRA to 'Unscheduled' - please set the fix version when this is ready for review

twomice · 2016-07-26T00:42:17Z

@nganivet I think this is ready for review; can you comment?

nganivet · 2016-07-26T16:24:57Z

Alan - we need to test this before it is released. Please tell me a time
you would be available in the short term, we need around 30 mins: you
install this PR on one of your instances and trigger a pingback, I can then
check that all is good on my end. If there are errors client or server side
we can correct and re-test.

On Mon, Jul 25, 2016 at 6:42 PM, twomice notifications@github.com wrote:

@nganivet https://github.com/nganivet I think this is ready for review;
can you comment?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8525 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADRqOzLgNqev0FWRiCnUD7TmyeyKlXlOks5qZVfrgaJpZM4Ivrj-
.

Nicolas Ganivet | Principal | nicolas@cividesk.com
cividesk | +1 (866) 670-7165 | www.cividesk.com

twomice · 2016-07-26T21:37:59Z

I did that back on June 19 (see #8525 (comment)). Perhaps you can check that? @nganivet

colemanw · 2016-09-30T22:57:53Z

@nganivet should have cornered you and @twomice to finish this at the sprint. Still not too late for you to take a look at it though. I'd appreciate it if you can.

nganivet · 2016-09-30T23:33:25Z

I looked at the Sprint and the tests did not make it to the pingback database. not sure if this is client side or server side though. I have asked @twomice to dump the data sent client-side so I can have a test data set to check on the server-side side.

twomice · 2016-10-02T01:16:17Z

Thanks for the reminder @nganivet . I've run the version_check scheduled job (just now, Oct 1, 2016, 8:12pm Central time) on my dev site, and here's what it should have sent (note "domain_isoCode=TM"):

version=4.7.9&hash=9a8278ea6fa26a053352bdf1e2ad3e2a&uf=Drupal&lang=en_US&co=1228&ufv=7.42-dev&PHP=5.6.4-4ubuntu6.4&MySQL=5.6.28-0ubuntu0.15.04.1&communityMessagesUrl=%2Adefault%2A&domain_isoCode=TM&PPTypes=Elavon+Payment+Processor&entities%5B0%5D%5Bname%5D=Activity&entities%5B0%5D%5Bsize%5D=623&entities%5B1%5D%5Bname%5D=Case&entities%5B1%5D%5Bsize%5D=0&entities%5B2%5D%5Bname%5D=Contact&entities%5B2%5D%5Bsize%5D=202&entities%5B3%5D%5Bname%5D=Relationship&entities%5B3%5D%5Bsize%5D=215&entities%5B4%5D%5Bname%5D=Campaign&entities%5B4%5D%5Bsize%5D=0&entities%5B5%5D%5Bname%5D=Contribution&entities%5B5%5D%5Bsize%5D=93&entities%5B6%5D%5Bname%5D=ContributionPage&entities%5B6%5D%5Bsize%5D=3&entities%5B7%5D%5Bname%5D=ContributionProduct&entities%5B7%5D%5Bsize%5D=0&entities%5B8%5D%5Bname%5D=Widget&entities%5B8%5D%5Bsize%5D=0&entities%5B9%5D%5Bname%5D=Discount&entities%5B9%5D%5Bsize%5D=0&entities%5B10%5D%5Bname%5D=PriceSetEntity&entities%5B10%5D%5Bsize%5D=6&entities%5B11%5D%5Bname%5D=UFGroup&entities%5B11%5D%5Bsize%5D=13&entities%5B12%5D%5Bname%5D=Event&entities%5B12%5D%5Bsize%5D=6&entities%5B13%5D%5Bname%5D=Participant&entities%5B13%5D%5Bsize%5D=50&entities%5B14%5D%5Bname%5D=Friend&entities%5B14%5D%5Bsize%5D=8&entities%5B15%5D%5Bname%5D=Grant&entities%5B15%5D%5Bsize%5D=0&entities%5B16%5D%5Bname%5D=Mailing&entities%5B16%5D%5Bsize%5D=0&entities%5B17%5D%5Bname%5D=Membership&entities%5B17%5D%5Bsize%5D=30&entities%5B18%5D%5Bname%5D=MembershipBlock&entities%5B18%5D%5Bsize%5D=1&entities%5B19%5D%5Bname%5D=Pledge&entities%5B19%5D%5Bsize%5D=3&entities%5B20%5D%5Bname%5D=PledgeBlock&entities%5B20%5D%5Bsize%5D=2&entities%5B21%5D%5Bname%5D=Delivered&entities%5B21%5D%5Bsize%5D=0&extensions%5B0%5D%5Bname%5D=org.civicrm.component.civievent&extensions%5B0%5D%5Benabled%5D=1&extensions%5B0%5D%5Bversion%5D=4.7.9&extensions%5B1%5D%5Bname%5D=org.civicrm.component.civicontribute&extensions%5B1%5D%5Benabled%5D=1&extensions%5B1%5D%5Bversion%5D=4.7.9&extensions%5B2%5D%5Bname%5D=org.civicrm.component.civimember&extensions%5B2%5D%5Benabled%5D=1&extensions%5B2%5D%5Bversion%5D=4.7.9&extensions%5B3%5D%5Bname%5D=org.civicrm.component.civimail&extensions%5B3%5D%5Benabled%5D=1&extensions%5B3%5D%5Bversion%5D=4.7.9&extensions%5B4%5D%5Bname%5D=org.civicrm.component.civireport&extensions%5B4%5D%5Benabled%5D=1&extensions%5B4%5D%5Bversion%5D=4.7.9&extensions%5B5%5D%5Bname%5D=org.civicrm.component.civipledge&extensions%5B5%5D%5Benabled%5D=1&extensions%5B5%5D%5Bversion%5D=4.7.9

This appears to have reached the remote server properly, as it returned this JSON string: {"4.7":{"status":"stable","releases":[{"version":"4.7.alpha1","date":"2015-09-23"},{"version":"4.7.alpha2","date":"2015-09-30"},{"version":"4.7.alpha3","date":"2015-10-07"},{"version":"4.7.alpha4","date":"2015-10-14"},{"version":"4.7.alpha5","date":"2015-10-21"},{"version":"4.7.beta1","date":"2015-12-03"},{"version":"4.7.beta2","date":"2015-12-09"},{"version":"4.7.beta3","date":"2015-12-15"},{"version":"4.7.beta4","date":"2015-12-23"},{"version":"4.7.beta5","date":"2015-12-30"},{"version":"4.7.beta6","date":"2016-01-06"},{"version":"4.7.beta7","date":"2016-01-12"},{"version":"4.7.beta8","date":"2016-01-20"},{"version":"4.7.0","date":"2016-01-27"},{"version":"4.7.1","date":"2016-02-03","security":"true"},{"version":"4.7.2","date":"2016-02-17"},{"version":"4.7.3","date":"2016-03-02","security":"true"},{"version":"4.7.4","date":"2016-03-16"},{"version":"4.7.5","date":"2016-04-06"},{"version":"4.7.6","date":"2016-04-07"},{"version":"4.7.7","date":"2016-05-04","security":"true"},{"version":"4.7.8","date":"2016-06-01","security":"true"},{"version":"4.7.9","date":"2016-07-05"},{"version":"4.7.10","date":"2016-08-03"},{"version":"4.7.11","date":"2016-09-07","security":"true"}]}}

eileenmcnaughton · 2017-03-19T06:41:30Z

@twomice @nganivet this is really old - looks like it is nearly there though?

nganivet · 2017-03-29T19:43:54Z

@Eileen - yes, sorry about that.
@twomice - I checked and the pingback is in the stats database, so we're good to merge. I sent you the data in a private email.

eileenmcnaughton · 2017-03-29T19:57:46Z

done!

twomice · 2017-03-29T20:22:07Z

It's great to see this get in, finally. Thanks Eileen and Nicolas!

civicrm-builder added the master label Jun 7, 2016

nganivet reviewed Jun 8, 2016
View reviewed changes

totten changed the title ~~Fix CRM-18251~~ CRM-18251 - Domain stats and VersionCheck Jun 11, 2016

twomice force-pushed the CRM-18251b branch from 280b0f3 to adf1a64 Compare June 16, 2016 17:13

Fix CRM-18251

142a9b5

twomice force-pushed the CRM-18251b branch from adf1a64 to 142a9b5 Compare June 16, 2016 17:15

JoeMurray mentioned this pull request Jul 7, 2016

Invitation: CiviCRM 4.7.10 release August 2016 civicrm/release-management#4

Closed

eileenmcnaughton merged commit 3aff619 into civicrm:master Mar 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRM-18251 - Domain stats and VersionCheck #8525

CRM-18251 - Domain stats and VersionCheck #8525

twomice commented Jun 7, 2016 •

edited

Loading

twomice commented Jun 7, 2016

twomice commented Jun 7, 2016

nganivet Jun 8, 2016

JoeMurray commented Jun 13, 2016

twomice commented Jun 13, 2016

twomice commented Jun 16, 2016

twomice commented Jun 17, 2016

totten commented Jun 17, 2016

twomice commented Jun 17, 2016

nganivet commented Jun 19, 2016

twomice commented Jun 20, 2016

twomice commented Jul 12, 2016

eileenmcnaughton commented Jul 19, 2016

eileenmcnaughton commented Jul 25, 2016

twomice commented Jul 26, 2016

nganivet commented Jul 26, 2016

twomice commented Jul 26, 2016

colemanw commented Sep 30, 2016

nganivet commented Sep 30, 2016

twomice commented Oct 2, 2016

eileenmcnaughton commented Mar 19, 2017

nganivet commented Mar 29, 2017

eileenmcnaughton commented Mar 29, 2017

twomice commented Mar 29, 2017

CRM-18251 - Domain stats and VersionCheck #8525

CRM-18251 - Domain stats and VersionCheck #8525

Conversation

twomice commented Jun 7, 2016 • edited Loading

twomice commented Jun 7, 2016

twomice commented Jun 7, 2016

nganivet Jun 8, 2016

Choose a reason for hiding this comment

JoeMurray commented Jun 13, 2016

twomice commented Jun 13, 2016

twomice commented Jun 16, 2016

twomice commented Jun 17, 2016

totten commented Jun 17, 2016

twomice commented Jun 17, 2016

nganivet commented Jun 19, 2016

twomice commented Jun 20, 2016

twomice commented Jul 12, 2016

eileenmcnaughton commented Jul 19, 2016

eileenmcnaughton commented Jul 25, 2016

twomice commented Jul 26, 2016

nganivet commented Jul 26, 2016

twomice commented Jul 26, 2016

colemanw commented Sep 30, 2016

nganivet commented Sep 30, 2016

twomice commented Oct 2, 2016

eileenmcnaughton commented Mar 19, 2017

nganivet commented Mar 29, 2017

eileenmcnaughton commented Mar 29, 2017

twomice commented Mar 29, 2017

twomice commented Jun 7, 2016 •

edited

Loading