CRM-18439 - support MySQL 5.7 sql_mode=only_full_group_by #8511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jitendrapurohit
commented
Jun 6, 2016
•
jitendrapurohit
commented
- CRM-18439: support MySQL 5.7 sql_mode=only_full_group_by
jitendrapurohit
force-pushed
the
CRM-18439
branch
4 times, most recently
from
7ec6bcb to
4e533a8
Compare
added 6 commits
July 12, 2016 10:49
jitendrapurohit
force-pushed
the
CRM-18439
branch
from
4e533a8 to
dc852c7
Compare
| $sqlMode = CRM_Core_DAO::singleValueQuery('SELECT @@sql_mode'); | ||
|
|
||
| //return if ONLY_FULL_GROUP_BY is not enabled. | ||
| if (!version_compare($mysqlVersion, '5.7', '<') && !empty($sqlMode) && in_array('ONLY_FULL_GROUP_BY', explode(',', $sqlMode))) { |
There was a problem hiding this comment.
Why do we do this? I understood the ONLY_FULL_GROUP_BY as forcing better queries - but I thought they would still be valid in pre 5.7?
There was a problem hiding this comment.
There are a few reason behind this-
-
Main reason being the
ANY_VALUEkeyword which is only introduced in 5.7+ which we use it here in some summary reports (Membership, Contribution, etc) which enforces the result to group by selected columns. -
MySQL 5.7+ has some enhancements to
ONLY_FULL_GROUP_BYmode that recognizes Functional Dependencies unlike in lower versions which work on blindly including all the select columns ingroup_byclause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.