CRM-16355 - reminders in multilingual sites fix

[samuelsov]

• CRM-16355: Reminders in multilingual sites: allow to define the language of the sending

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@xurizaemon can you look at this!!!

[JoeMurray]

Samuel, comme Release Manager ce mois-ci, je suis en train de recruter des gens pour aider à parer l'arriéré de près de 100 PRs, dont certaines remontent à l'été dernier. Je me demande si vous seriez en mesure d'aider AQ autres PRs si je trouve quelqu'un d'AQ ce PR et / ou vos autres # 8538 # 7276?

[samuelsov]

@JoeMurray : yes !

[eileenmcnaughton]

Oui?

[JoeMurray]

Samuel agreed to help QA others' PRs if I get someone to help QA his.

[JoeMurray]

@mpnordland willing to try to QA this PR?

[eileenmcnaughton]

pretty sure I saw a PR merged recently which does this getLocale bit here

[MegaphoneJon]

@samuelsov @JoeMurray I have an affected site in production, I'll QA this!

[MegaphoneJon]

OK, I just ran this through its paces.
First - I confirm that this fixes the issue with sending scheduled reminders on multilingual sites.

Reading through the code, everything makes sense, but two things caught my eye:

• There's a FIXME that says to revisit when CRM-18362 is fixed - which it is.
• I don't understand why there's a fallback to pre-4.5 mode. Is this necessary? Or is this because the code was backported to a pre-4.5 client and this got left in the PR?

[samuelsov]

• about the FIXME, you are right, it's now in Core, i will remove this part
• not sure either, i suppose it's a failsafe attitude... people have the choice of putting their mo files either with or without LC_MESSAGES but the civicrm_l10n files are shipped with the new structure so i guess we don't have to support it for ever... If we remove it there, we should remove it from the constructor to be consistent.

[samuelsov]

@PalanteJon : Ok, the patch is ready to be validated again.
I have not fixed the fallback to pre-4.5 mode but i have created two helper function so that at least, there is no duplication of code (setNativeGettextLocale and setPhpGettextLocale) - they are used in the constructor and in the setLocale function. It will be easier to remove the fallback (but it's not quite the goal of this issue).

[samuelsov]

The failed tests seems to be unrelated to the patch ("Incomplete Test").

[colemanw]

@civicrm-builder retest this please

[monishdeb]

Merged on pass :)