CRM-18656 Advanced search fails to show tagset criteria

[kenwest]

When editing a saved search, tagset criteria don't show.

This occurs because on the form the tagsets are displayed separately to other tags, while in the saved search they are all stored together. When retrieved from the saved search, the tagset tags need to be separated again.

The function that 'normalises' the tags so they are all stored together in the saved search is CRM_Contact_Form_Search_Advanced::normalizeFormValues(). On the form, normal tags are stored in an element named 'contact_tags' while tagset tags are stored in elements named 'contact_taglist[23]' where '23' is the Id of the tagset. normalizeFormValues() converts them all to parameters with name 'contact_tags' (the queries can use the IN operator on all the tag values: they don't care about tagsets).

What's needed is some code that reverses this. This patch ...

1. Does no harm if the $defaults don't need this processing
2. Looks at each 'contact_tags' default to see if it is a tagset tag
3. If it is, move the 'contact_tags' element to an array like 'contact_taglist[23]'
4. Cleans up the 'contact_tags' array

---

• CRM-18656: Advanced search fails to show tagset criteria when editing saved search

[colemanw]

@kenwest the stylechecker says:

Advanced.php:403 - There should be no white space after an opening "{"

[jitendrapurohit]

cherry-picked the commits and created a new PR at #8596 with little optimisation.

[monishdeb]

Closing in favor of #8596