Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-18528 - unit test to check group filter #8414

Closed
wants to merge 2 commits into from
Closed

CRM-18528 - unit test to check group filter #8414

wants to merge 2 commits into from

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented May 20, 2016 •
edited
Loading

@jitendrapurohit
Copy link
Contributor Author

jenkins, test this please

@jitendrapurohit
Copy link
Contributor Author

test works on local, but fails here. Can jenkins be not updated with former PR #8366?

@jitendrapurohit
Copy link
Contributor Author

jenkins, test this please

@eileenmcnaughton
Copy link
Contributor

That PR you mentioned is merged - but I don't see $_GET['is_unit_test'] being set in your test?

Yay for the test!!

@jitendrapurohit
Copy link
Contributor Author

jitendrapurohit commented May 21, 2016 •
edited
Loading

'is_unit_test' is set in $this->_params which i assign it to $_GET.

Need to figure out why it fails on jenkins.

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

ok to test

@eileenmcnaughton
Copy link
Contributor

Looks like it is running https://test.civicrm.org/job/CiviCRM-Core-PR/10131/console but it's still showing pending'

@jitendrapurohit
Copy link
Contributor Author

Jenkins, test this please

@JoeMurray JoeMurray mentioned this pull request Jul 7, 2016
Closed
@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@totten another one that doesn't want to fire?

@eileenmcnaughton
Copy link
Contributor

test this please

@yashodha
Copy link
Contributor

Jenkins test this please

@monishdeb monishdeb closed this Jul 20, 2016
@jitendrapurohit jitendrapurohit deleted the CRM-18528-tests branch July 20, 2016 11:18
@jitendrapurohit jitendrapurohit restored the CRM-18528-tests branch July 20, 2016 11:19
@monishdeb
Copy link
Member

Closed in favor of #8729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jitendrapurohit @eileenmcnaughton @yashodha @monishdeb @civicrm-builder