Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-18504 fix validation error when contact subtype is disabled #8405

Merged
merged 1 commit into from
May 19, 2016
Merged

CRM-18504 fix validation error when contact subtype is disabled #8405

merged 1 commit into from
May 19, 2016

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 18, 2016 •
edited by civicrm-builder
Loading

@eileenmcnaughton eileenmcnaughton mentioned this pull request May 18, 2016
Closed
@totten
Copy link
Member

totten commented May 19, 2016

@davejenx @xurizaemon @seamuslee001 @JKingsnorth - could you help with QA'ing this one so that we can get it into the release-candidate for 4.7.8 (ETA Friday)?

@seamuslee001
Copy link
Contributor

I've done some preliminary tests on one of our test sites and tested accessing a contact that caused issues previously in regards to the validation. I think this looks pretty safe to go IMO

@eileenmcnaughton
Copy link
Contributor Author

OK giving it 'merge on pass' based on that

@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton merged commit e95182e into civicrm:master May 19, 2016
@eileenmcnaughton eileenmcnaughton deleted the custom_data-regress branch May 19, 2016 05:30
@davejenx
Copy link
Contributor

Replicated issue with a CF set extending a disabled contact subtype on 4.7.7 / D7 - had to enable Views & go to /admin/structure/views to get the error.

Applied patches #8389 (needed in order to get this patch to apply) & the CRM/Core/BAO/CustomGroup.php part of #8405 (the CRM/Contact/BAO/ContactType.php part was already in 4.7.7) .

Result: success: this got rid of the error.

@eileenmcnaughton
Copy link
Contributor Author

Great I think we just need this back on 4.6 & we are done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eileenmcnaughton @totten @seamuslee001 @davejenx @civicrm-builder