CRM-18070: Packaged eWAY classes not loaded for Event registration #8300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
monishdeb
commented
May 5, 2016
•
monishdeb
commented
- CRM-18070: Packaged eWAY classes not loaded for Event registration
|
Monish, my feeling is that these should just go at the top of the file rather than within a specific function. It doesn't matter hugely but it seems to cover all cases |
|
Done and working fine. @eileenmcnaughton can you please verify my patch and merge!! |
|
Adding merge on pass because I'm happy once the style issue is fixed & tests pass. NB I haven't personally tested this on eway since I'm happy with it visually but will incorporate some eway tests into code week |
|
Test build failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.