civicrm/admin/reltype - Fix warning #8299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scenario:
1. Create a new relationship-type. It should target "All Contacts" (not "Individual" or "Organization"). (Note: In the schema, "All Contacts" translates to `contact_type_a=NULL`.)
2. Reload the list of relationship-types
3. Observe: Warnings
Notes:
1. The relationship type appears to work correctly if you try to create
relationship-instances, so this feels like a cosmetic issue on the listing
screen.
2. What a silly place for that code live. Keep calm and carry on.
|
Jenkins re test this please |
|
Opened up list of relationships in test box that already had some relationships for all contacts. |
|
Based on Seamus's QA & the code being simply the addition of a check for the variable I'm merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
contact_type_a=NULL.)Notes:
relationship-instances, so this feels like a cosmetic issue on the listing
screen.